Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @types/node from 14.0.0 to 14.11.2 #364

Merged
merged 2 commits into from
Oct 22, 2020

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 1, 2020

Bumps @types/node from 14.0.0 to 14.11.2.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team October 1, 2020 05:02
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 1, 2020
@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@8cfcb1d). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #364   +/-   ##
=========================================
  Coverage          ?   93.43%           
=========================================
  Files             ?       16           
  Lines             ?     1554           
  Branches          ?      265           
=========================================
  Hits              ?     1452           
  Misses            ?      102           
  Partials          ?        0           
Impacted Files Coverage Δ
packages/desktopjs/src/menu.ts 100.00% <0.00%> (ø)
packages/desktopjs/src/container.ts 95.33% <0.00%> (ø)
packages/desktopjs/src/propertymapping.ts 100.00% <0.00%> (ø)
packages/desktopjs/src/desktop.ts 100.00% <0.00%> (ø)
packages/desktopjs/src/screen.ts 100.00% <0.00%> (ø)
packages/desktopjs/src/notification.ts 100.00% <0.00%> (ø)
packages/desktopjs-openfin/src/openfin.ts 87.67% <0.00%> (ø)
packages/desktopjs-electron/src/electron.ts 97.10% <0.00%> (ø)
packages/desktopjs/src/guid.ts 100.00% <0.00%> (ø)
packages/desktopjs/src/Default/default.ts 94.62% <0.00%> (ø)
... and 6 more

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/types/node-14.11.2 branch from cbc71b5 to 644564c Compare October 2, 2020 14:59
@Brookke
Copy link
Contributor

Brookke commented Oct 22, 2020

Seems sensible @bingenito mind approving this?

@bingenito
Copy link
Member

@Brookke I've been lazy on this one because it is a very noisy dependency as far as reoccurring upgrades that have no real tangible impact on the project. I was keeping it as a placeholder to remind me to add it to the ignore list. With that said, since I changed the dependabot updates to be monthly I can accept this and just let them come in.

@bingenito bingenito merged commit 3c832b7 into master Oct 22, 2020
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/types/node-14.11.2 branch October 22, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants