Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated apis not available in OpenFin v22 #635

Merged
merged 3 commits into from
Feb 16, 2023

Conversation

ilzep
Copy link
Contributor

@ilzep ilzep commented Feb 16, 2023

OpenFin v22 has deprecated a number of APIs that are used in this project. Removing references to grouping and notification APIs that are no longer available.

@ilzep ilzep requested a review from a team as a code owner February 16, 2023 10:55
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #635 (671caed) into main (f0c1fdc) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head 671caed differs from pull request most recent head 9ab9637. Consider uploading reports for the commit 9ab9637 to get more accurate results

@@            Coverage Diff             @@
##             main     #635      +/-   ##
==========================================
- Coverage   93.85%   93.78%   -0.08%     
==========================================
  Files          16       16              
  Lines        1482     1464      -18     
  Branches      262      257       -5     
==========================================
- Hits         1391     1373      -18     
  Misses         90       90              
  Partials        1        1              
Flag Coverage Δ
unittests 93.78% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/desktopjs-openfin/src/openfin.ts 87.39% <100.00%> (-0.62%) ⬇️

Copy link
Member

@bingenito bingenito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. tested PR locally and checks out

@bingenito bingenito merged commit c1dacae into morganstanley:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants