Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout parameter in stepEventLoop gets ignored #436

Open
mo-xiaoming opened this issue Feb 24, 2022 · 0 comments
Open

Timeout parameter in stepEventLoop gets ignored #436

mo-xiaoming opened this issue Feb 24, 2022 · 0 comments

Comments

@mo-xiaoming
Copy link
Contributor

If the timeoutMS parameter is anything other than -1

  1. If there are any timers, this timeout gets ignored
  2. otherwise, epoll_wait timeouts out on this, but stepEventLoop doesn't exit
staging-devin-ai-integration bot added a commit to cg-cognition/hobbes that referenced this issue Dec 7, 2024
@staging-devin-ai-integration
Fix stepEventLoop timeout handling
c7acf52 
- Respect user-provided timeout when timers exist
- Exit loop when epoll_wait times out with no events/timers

Fixes morganstanley#436
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix stepEventLoop timeout handling cg-cognition/hobbes
1 participant
@mo-xiaoming