Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for named constant when auto resolving params. #37

Merged
merged 2 commits into from
Mar 4, 2021
Merged

Add support for named constant when auto resolving params. #37

merged 2 commits into from
Mar 4, 2021

Conversation

Davidhanson90
Copy link
Contributor

factory.create(AUTO_RESOLVE, 4);

instead of

factory.create(undefined, 4);

@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #37 (8b4b117) into main (5f0b5ae) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   94.41%   94.42%           
=======================================
  Files          23       23           
  Lines         591      592    +1     
  Branches      106      106           
=======================================
+ Hits          558      559    +1     
  Misses         13       13           
  Partials       20       20           
Impacted Files Coverage Δ
main/constants/constants.ts 100.00% <100.00%> (ø)

@Davidhanson90 Davidhanson90 merged commit 787cff1 into morganstanley:main Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants