Addressed reviewer request

morganstanley · Aug 24, 2023 · 63f7103 · 63f7103
1 parent 8e22ac1
commit 63f7103
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 27 deletions.
diff --git a/doc/newsfragments/2404_new.run_all_button.rst b/doc/newsfragments/2404_new.run_all_button.rst
@@ -1 +1 @@
-Added a new "Run all MultiTests" button to toolbar on the interactive GUI.
+Introduced a new plan-level Run button to the toolbar on the interactive GUI.
diff --git a/testplan/web_ui/testing/src/Toolbar/InteractiveButtons.js b/testplan/web_ui/testing/src/Toolbar/InteractiveButtons.js
@@ -165,35 +165,25 @@ export const RunAllButton = (props) => {
       </NavItem>
     );
   } else {
+    let title;
     if (props.filter) {
-      return (
-        <NavItem key="runall-button">
-          <div className={css(styles.buttonsBar)}>
-            <FontAwesomeIcon
-              key="toolbar-runall"
-              className={css(styles.toolbarButton)}
-              icon={faPlay}
-              title="Run filtered tests"
-              onClick={props.runAllCbk}
-            />
-          </div>
-        </NavItem>
-      );
+      title="Run filtered tests";
     } else {
-      return (
-        <NavItem key="runall-button">
-          <div className={css(styles.buttonsBar)}>
-            <FontAwesomeIcon
-              key="toolbar-runall"
-              className={css(styles.toolbarButton)}
-              icon={faPlay}
-              title="Run all tests"
-              onClick={props.runAllCbk}
-            />
-          </div>
-        </NavItem>
-      );
+      title="Run all tests";
     }
+    return (
+      <NavItem key="runall-button">
+        <div className={css(styles.buttonsBar)}>
+          <FontAwesomeIcon
+            key="toolbar-runall"
+            className={css(styles.toolbarButton)}
+            icon={faPlay}
+            title={title}
+            onClick={props.runAllCbk}
+          />
+        </div>
+      </NavItem>
+    );
   }
 };
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		Added a new "Run all MultiTests" button to toolbar on the interactive GUI.
		Introduced a new plan-level Run button to the toolbar on the interactive GUI.