Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remediate security scan finding #1096

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

kn-ms
Copy link
Contributor

@kn-ms kn-ms commented Jun 4, 2024

Bug / Requirement Description

Clearly and concisely describe the problem.

actions consume github and other 3rd party actions with version tag. Best practice say consume it with the fixed hash.

Also set default permission to content read where we need to use some more powerfull permissions for some jibs.

Solution description

  • pin actions versions
  • limit permissions

Checklist:

  • Test
  • Example (both test_plan.py and .rst)
  • Documentation (API)
  • News fragment present for release notes
  • MS info leakage check
  • For new driver: driver index page
  • For new assertion: ui/pdf/std renderers, documentation
  • For new cmdline arg: documentation

- pin actions versions
- limit permissions
@kn-ms kn-ms requested a review from a team as a code owner June 4, 2024 21:19
@kn-ms kn-ms merged commit ab67547 into morganstanley:main Jun 5, 2024
15 checks passed
@kn-ms kn-ms deleted the fix/pin_action_deps branch June 5, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants