Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine auto-parts logic #1098

Merged
merged 1 commit into from
Jun 6, 2024
Merged

refine auto-parts logic #1098

merged 1 commit into from
Jun 6, 2024

Conversation

Pyifan
Copy link
Contributor

@Pyifan Pyifan commented Jun 6, 2024 •
edited
Loading

Bug / Requirement Description

Make Auto-Part corner case handling more robust.

Solution description

try-except divide by zero
0/negative number of parts --> 1
cap number of parts

Checklist:

  • Test
  • Example (both test_plan.py and .rst)
  • Documentation (API)
  • News fragment present for release notes
  • MS info leakage check
  • For new driver: driver index page
  • For new assertion: ui/pdf/std renderers, documentation
  • For new cmdline arg: documentation

@Pyifan Pyifan requested a review from a team as a code owner June 6, 2024 03:55
@Pyifan Pyifan merged commit 5a1e45e into morganstanley:main Jun 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuxuan-ms yuxuan-ms yuxuan-ms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pyifan @yuxuan-ms