Fix/empty dict to dependencies indicating all drivers start concurrently #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pyifan
requested changes
Jun 20, 2024
testplan/testing/base.py
Outdated
| @@ -112,7 +112,7 @@ def get_options(cls): | |||
| [Or(Resource, RemoteDriver)], validate_func() | |||
| ), | |||
| ConfigOption("dependencies", default=None): Or( | |||
| Use(parse_dependency), validate_func() | |||
| None, Use(parse_dependency), validate_func() | |||
There was a problem hiding this comment.
suggest we get rid of dependencies=None usage
it easily confuses with dependencies=[]
testplan/testing/base.py
Outdated
| else: | ||
| deps = self.cfg.dependencies | ||
| if deps: | ||
| if deps is not None: |
There was a problem hiding this comment.
Do a None check in set_dependency and make this piece of code simpler?
| @@ -0,0 +1 @@ | |||
| Users now can make all drivers of a certain ``Test`` start concurrently by passing an empty dict to ``dependencies`` argument. | |||
There was a problem hiding this comment.
update the dependencies arg doc
| dependencies=dependencies, | ||
| initial_context={"is_set": is_set}, | ||
| environment=lambda: list(drivers.values()) | ||
| if is_lift |
There was a problem hiding this comment.
why is this param named is_lift, shall we call it use_callable?
zhenyu-ms
force-pushed
the
fix-driver-dep
branch
from
e54a116 to
a878002
Compare
Pyifan
approved these changes
Jun 20, 2024
zhenyu-ms
changed the title
zhenyu-ms
force-pushed
the
fix-driver-dep
branch
from
a878002 to
512b09d
Compare
zhenyu-ms
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug / Requirement Description
Clearly and concisely describe the problem.
Solution description
Describe your code changes in detail for reviewers.
Checklist: