Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display multitest setup and teardown times on webUI #1104

Merged
merged 8 commits into from
Jul 10, 2024

Conversation

rnemes
Copy link
Contributor

@rnemes rnemes commented Jun 20, 2024

Bug / Requirement Description

Users would like to see multitest setup and teardown duration on the Nav bar.

Checklist:

  • Test
  • Example (both test_plan.py and .rst)
  • Documentation (API)
  • News fragment present for release notes
  • MS info leakage check
  • For new driver: driver index page
  • For new assertion: ui/pdf/std renderers, documentation
  • For new cmdline arg: documentation

@rnemes rnemes marked this pull request as ready for review June 24, 2024 17:04
@rnemes rnemes requested a review from a team as a code owner June 24, 2024 17:04
}
return elapsed < 0 ? null : elapsed;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

under interactive mode, if we start/stop multitest multiple times, do we get multiple timer entries (or maybe we wipe out the timer when we restart)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

during my testing, it always had one element

@rnemes rnemes merged commit f072070 into morganstanley:main Jul 10, 2024
15 checks passed
@rnemes rnemes deleted the setupteardowntimes branch July 10, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants