Fix/issues related to driver dependency #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix exception handling within pre_resource steps - fix driver flag setting when driver dependency presents
zhenyu-ms
force-pushed
the
fix-pre-resources
branch
from
e5f1ad0 to
9fb6112
Compare
Pyifan
requested changes
Jul 8, 2024
testplan/testing/base.py
Outdated
| else: | ||
| self.resources._initial_context = self.cfg.initial_context | ||
| except Exception as e: | ||
| self.resources.self_exception = e |
There was a problem hiding this comment.
can we re-use the try-except in _execute_step rather than adding try-except to every single step?
zhenyu-ms
force-pushed
the
fix-pre-resources
branch
from
7451189 to
1356e61
Compare
Pyifan
approved these changes
Jul 16, 2024
zhenyu-ms
changed the title
zhenyu-ms
added a commit
to zhenyu-ms/testplan
that referenced
this pull request
Jul 16, 2024
* fix two bugs - fix exception handling within pre_resource steps - fix driver flag setting when driver dependency presents * have post_run_checks warning written to log file * address review comments; add support of dependencies=None * really address review comments; bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug / Requirement Description
dependenciesarg acceptNoneor callable returningNone(sort of optional)Solution description
Checklist: