Feature/more debug logging to LogMatcher #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhenyu-ms
force-pushed
the
logmatcher-pos
branch
3 times, most recently
from
381fd11 to
d4a3736
Compare
Pyifan
reviewed
Jul 16, 2024
testplan/common/utils/match.py
Outdated
| self._debug_info_e = ( | ||
| str(self.position), | ||
| time.time(), | ||
| _truncate_line(line), |
There was a problem hiding this comment.
if we are reaching eof but not finding the pattern, more useful info would be the last line seen, rather than eof
zhenyu-ms
force-pushed
the
logmatcher-pos
branch
from
d4a3736 to
a1dd123
Compare
Pyifan
previously approved these changes
Jul 16, 2024
zhenyu-ms
force-pushed
the
logmatcher-pos
branch
from
d577cd5 to
6b643b5
Compare
yuxuan-ms
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug / Requirement Description
to add debug logging in logmatcher public apis
Solution description
having method
_matchas internal impl, debug logging info attached toself, set toNoneto allow info loggingChecklist: