Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FixLog missing sort buttons #1115

Merged
merged 3 commits into from
Jul 17, 2024
Merged

FixLog missing sort buttons #1115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbb2deb
Fixed FixLog missing sort buttons
rnemes Jul 16, 2024
54f8052
Added newsfragment
rnemes Jul 16, 2024
d409216
Merge branch 'main' into fixLogSort
rnemes Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/newsfragments/2945_fix.fixlog_sort_button.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed FixLog assertion not showing sort buttons on the web UI.
2 changes: 1 addition & 1 deletion testplan/web_ui/testing/src/AssertionPane/AssertionTypes/DictAssertions/FixLogAssertion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export default function FixLogAssertion(props) {

return (
<DictBaseAssertion
buttonGroup={buttonGroup}
buttons={buttonGroup}
columns={columns}
rows={prepareDictRowData(rowData, props.assertion.line_no)}
/>
Expand Down
2 changes: 1 addition & 1 deletion ...onPane/AssertionTypes/DictAssertions/__tests__/__snapshots__/FixLogAssertion.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

exports[`FixLogAssertion shallow renders the correct HTML structure 1`] = `
<DictBaseAssertion
buttonGroup={
buttons={
<DictButtonGroup
defaultSortType={Symbol(NONE)}
flattenedDict={
Expand Down