Add --code flag for collecting code context. #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnemes
commented
Dec 11, 2024
| * @param {String} path | ||
| */ | ||
| export const getWorkspacePath = (path) => { | ||
| const srcIndex = path.indexOf('/src/'); |
There was a problem hiding this comment.
This only works on linux
There was a problem hiding this comment.
(Discussed this offline.) This is a request from management, the full path will be visible in the popup.
Pyifan
requested changes
Dec 13, 2024
| if enabled. | ||
| """ | ||
| return getattr(self.cfg, "collect_code_context", False) | ||
|
|
There was a problem hiding this comment.
is this just for orphan multitest in testing?
There was a problem hiding this comment.
might need it for hooks & maybe result call under pytest wrapper
Pyifan
requested changes
Dec 13, 2024
rnemes
changed the title
Pyifan
requested changes
Dec 17, 2024
Pyifan
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug / Requirement Description
Include the 1 liner of the testcase assertion (top-level from testcase) into the report.
Solution description
Added
--codeflag to collect code context for the assertions. Code context one-liner will be displayed on the web UI if enabled.Note that file path information is no longer collected by default. To collect file path information, enable code context.
Checklist: