Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testplan result importer to best effort fix attachment path #1162

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

Pyifan
Copy link
Contributor

@Pyifan Pyifan commented Dec 18, 2024

Bug / Requirement Description

When we copy report.json and _attachment around, we are not able to locate the attachments after import json.

Solution description

Best effort fix attachment path by checking local _attachment dir.

Checklist:

  • Test
  • Example (both test_plan.py and .rst)
  • Documentation (API)
  • News fragment present for release notes
  • MS info leakage check
  • For new driver: driver index page
  • For new assertion: ui/pdf/std renderers, documentation
  • For new cmdline arg: documentation

@Pyifan Pyifan requested a review from a team as a code owner December 18, 2024 06:26
@Pyifan Pyifan force-pushed the admin branch 3 times, most recently from 611a6ca to eb6c7c7 Compare December 18, 2024 10:02
Copy link
Contributor

@zhenyu-ms zhenyu-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pyifan Pyifan merged commit d9520ee into morganstanley:main Dec 18, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants