Add Kafka driver #476
Merged
Add Kafka driver #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuxuan-ms
force-pushed
the
kafka
branch
9 times, most recently
from
28f2546 to
af05357
Compare
Pyifan
reviewed
Aug 24, 2020
| @@ -0,0 +1,107 @@ | |||
| #!/usr/bin/env python | |||
| """ | |||
| Demostrates Zookeeper driver usage from within the testcases. | |||
Pyifan
reviewed
Aug 24, 2020
| ConfigOption("cfg_template"): str, | ||
| ConfigOption("zookeeper_connect"): Or(str, context.is_context), | ||
| ConfigOption("port"): int, | ||
| ConfigOption("env", default=None): Or(None, dict), |
There was a problem hiding this comment.
env is already available in App driver
Pyifan
reviewed
Aug 24, 2020
| self.config = None | ||
| self.port = port | ||
|
|
||
| def pre_start(self): |
There was a problem hiding this comment.
Can we use App's pre_start as well?
Pyifan
reviewed
Aug 24, 2020
| def get_options(cls): | ||
| return { | ||
| ConfigOption("cfg_template"): str, | ||
| ConfigOption("zookeeper_connect"): Or(str, context.is_context), |
There was a problem hiding this comment.
If this is only used in config file, maybe we don't need this ConfigOption? We can refer to zk driver's property directly in kafka's config file.
yuxuan-ms
force-pushed
the
kafka
branch
4 times, most recently
from
72e2375 to
58d022a
Compare
Pyifan
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.