Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix minor issues of interactive mode #988

Merged
merged 2 commits into from
Aug 30, 2023
Merged

fix minor issues of interactive mode #988

merged 2 commits into from
Aug 30, 2023

Conversation

Pyifan
Copy link
Contributor

@Pyifan Pyifan commented Aug 30, 2023

Bug / Requirement Description

Fix an exception that happens during env shutdown

Solution description

Describe your code changes in detail for reviewers.

Checklist:

  • Test
  • Example (both test_plan.py and .rst)
  • Documentation (API)
  • News fragment present for release notes
  • MS info leakage check
  • For new driver: driver index page
  • For new assertion: ui/pdf/std renderers, documentation
  • For new cmdline arg: documentation

@Pyifan Pyifan merged commit 69c082d into morganstanley:main Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhenyu-ms zhenyu-ms zhenyu-ms approved these changes

@yuxuan-ms yuxuan-ms yuxuan-ms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pyifan @yuxuan-ms @zhenyu-ms