Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enlarge abort_wait_timeout to fix leftover driver #992

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Enlarge abort_wait_timeout to fix leftover driver #992

merged 1 commit into from
Sep 27, 2023

Conversation

Pyifan
Copy link
Contributor

@Pyifan Pyifan commented Sep 21, 2023

Bug / Requirement Description

When we abort testplan from interactive UI, timeout kicks-in before all driver are stopped.

Solution description

  1. Enlarge the abort_wait_timeout
  2. Suppress the exception of abort_wait_timeout so that abort will continue
  3. Remove an unnecessary wait

Checklist:

  • Test
  • Example (both test_plan.py and .rst)
  • Documentation (API)
  • News fragment present for release notes
  • MS info leakage check
  • For new driver: driver index page
  • For new assertion: ui/pdf/std renderers, documentation
  • For new cmdline arg: documentation

yuxuan-ms
yuxuan-ms previously approved these changes Sep 22, 2023
View reviewed changes
@Pyifan Pyifan force-pushed the bugfix branch 8 times, most recently from 9ba46b4 to 7133227 Compare September 27, 2023 02:32
@Pyifan Pyifan merged commit 022fb82 into morganstanley:main Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuxuan-ms yuxuan-ms yuxuan-ms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pyifan @yuxuan-ms