Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose lookup types #28

Merged
merged 6 commits into from
Jan 4, 2021
Merged

Conversation

Roaders
Copy link
Member

@Roaders Roaders commented Jan 4, 2021

This PR adds correct typing to the function call looks up exposed on IMocked: functionCallLookup, setterCallLookup, getterCallLookup, staticFunctionCallLookup, staticSetterCallLookup, staticGetterCallLookup.

It also fixes a bug where one a function had been resolved from a mocked object, changes to the mocked implementation were not reflected in the previously resolved function.

@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #28 (c2bccf5) into master (fc708d8) will decrease coverage by 1.09%.
The diff coverage is 91.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   96.37%   95.28%   -1.10%     
==========================================
  Files          11       12       +1     
  Lines         359      403      +44     
  Branches       52       63      +11     
==========================================
+ Hits          346      384      +38     
- Misses          4        6       +2     
- Partials        9       13       +4     
Impacted Files Coverage Δ
main/mock/mock.ts 100.00% <ø> (ø)
main/helper/lookup-helper.ts 90.00% <90.00%> (ø)
main/mock/operators.ts 92.39% <91.02%> (-3.91%) ⬇️
main/helper/index.ts 100.00% <100.00%> (ø)
main/mock/verifiers.ts 96.61% <100.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc708d8...c2bccf5. Read the comment docs.

Copy link
Contributor

@Davidhanson90 Davidhanson90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@Roaders Roaders merged commit b5d9c1b into morganstanley:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants