-
-
Notifications
You must be signed in to change notification settings - Fork 121
Conversation
The travis build server needs kafka + zookeeper instances running for this to build. |
"hello_42_there", | ||
{topic: "hello_42", encoding: "utf8"}, | ||
{topic: "image", encoding: "buffer"} | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the kind of behavior that should be handled inside Ascoltatori. Topics should be created automatically by the library, rather than predefined in the configuration.
Impressive work! Thanks so much for contributing this, I have added a comments, mostly on the API/configuration side. |
var offset = new kafka.Offset(client); | ||
offset.fetch(partitions, function (err, data) { | ||
var offsets = []; | ||
//TODO handle err |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
err should be handled
Not sure why some of those CI tests are failing for mongodb sometimes, or how it could be related to any changes I made....
|
So, we need node v0.12 support and old MongoDB support, but don't care too much about MongoDB. Regarding 0.12, just care about Kafka support. |
No description provided.