Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

Kafka use high level consumer #159

Merged

Conversation

sanchuvarkey-accesso
Copy link
Contributor

Added an option to use Kafka high level consumer. By default system uses the simple consumer and this can be overridden

Sanchu Varkey added 2 commits November 18, 2016 11:35
@coveralls
Copy link

coveralls commented Nov 18, 2016

Coverage Status

Coverage decreased (-0.1%) to 92.654% when pulling 0a3cf9b on svarkey:kafka_use_high_level_consumer into 68333a5 on mcollina:master.

@mcollina
Copy link
Collaborator

Can you please add some tests for this? Probably we need to run the full abstract suite with this option enabled, see https://github.com/mcollina/ascoltatori/blob/master/test/kafka_ascoltatore_spec.js.

@sanchuvarkey-accesso
Copy link
Contributor Author

@mcollina Sure i can add tests But how can i run kafka test suite? Is it some kinda run time variables. Can you please help me on this

Also i notice the existing builds are failing

@mcollina
Copy link
Collaborator

You will need to double https://github.com/mcollina/ascoltatori/blob/master/test/kafka_ascoltatore_spec.js with the new setting.

Mongo is flaky :(, don't worry.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 92.778% when pulling a0b227c on svarkey:kafka_use_high_level_consumer into 68333a5 on mcollina:master.

@sanchuvarkey-accesso
Copy link
Contributor Author

Added tests to cover this new setting. Please review

Thanks
Sanchu

@coveralls
Copy link

coveralls commented Nov 23, 2016

Coverage Status

Coverage increased (+0.02%) to 92.778% when pulling a0b227c on svarkey:kafka_use_high_level_consumer into 68333a5 on mcollina:master.

@mcollina mcollina merged commit c4c32f4 into moscajs:master Nov 24, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants