ZMQ -> ZeroMQ #190

shadyvd · 2018-07-29T09:49:31Z

Fix for #188 - Since the API are almost exactly the same, this should be a drop-in replacement

coveralls · 2018-07-29T09:55:07Z

Coverage remained the same at 92.853% when pulling a69eb26 on shadyvd:master into e920a53 on mcollina:master.

coveralls · 2018-07-29T09:55:07Z

Coverage increased (+0.02%) to 92.87% when pulling c34d37c on shadyvd:master into e920a53 on mcollina:master.

…ting

…uild testing" This reverts commit fbdcea4.

mcollina

Can you make this try requiring zmq first and then zeromq? In this way it won't be semver-major.

…he requirement for a major version change for the release

…to ZeroMQ on node.js V10

shadyvd · 2018-08-02T04:51:27Z

Done. But the Travis build fails on either V6 or V8 - am not sure why. It always clears V4 and V10.

mcollina · 2018-08-06T07:58:06Z

CI is a bit flaky :/

shadyvd · 2018-08-06T10:00:17Z

Ha ha, yes. Thanks for the merge. I'll try and get to upgrading the Kafka adapter in a few days.

ZMQ -> ZeroMQ

a69eb26

shadyvd added 2 commits July 29, 2018 16:39

Updated kafka-node dependency, added node 8+ dependency for build tes…

fbdcea4

…ting

Revert "Updated kafka-node dependency, added node 8+ dependency for b…

943b43c

…uild testing" This reverts commit fbdcea4.

mcollina reviewed Jul 29, 2018

View reviewed changes

shadyvd added 6 commits August 2, 2018 09:54

Added node.js v8 and node.js v10 to the testing mix

a734e84

Minor fix

12d8083

package.json changes

4ea37ba

Try the (old) zmq module before trying the zeromq module - prevents t…

76157ec

…he requirement for a major version change for the release

Reverting node-kafka to ~0.5.8

46e5a71

Re-include zmq in package.json - use it on node.js < V8, but upgrade …

c34d37c

…to ZeroMQ on node.js V10

mcollina merged commit 651cf4e into moscajs:master Aug 6, 2018

Provide feedback