Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

Addressing MongoAscoltatore 'close' bug #68

Merged
merged 2 commits into from
Jul 6, 2013
Merged

Addressing MongoAscoltatore 'close' bug #68

merged 2 commits into from
Jul 6, 2013

Conversation

mcollina
Copy link
Collaborator

@mcollina mcollina commented Jul 5, 2013

There are some spurious errors when closing a MongoAscoltatore.

This pull-request rewrites entirely the 'close' method, trying to solve the issue once and for all.

@davedoesdev could you please try it on your machine?

@davedoesdev
Copy link
Collaborator

Tests pass here.
Mongo stuff is much better!
Regarding the commented out test. I agree it didn't really test much but I'm relying on passing a function to ascoltatori.build. I wonder if a good way to test it would be to pass one of the existing ascoltatores as a function with some settings?

@davedoesdev
Copy link
Collaborator

Ah, I think I can modify can_be_used_by_ascoltatori.js to incorporate that so go ahead and merge this pull request. I'll do another one for passing type as a function.

mcollina added a commit that referenced this pull request Jul 6, 2013
Addressing MongoAscoltatore 'close' bug
@mcollina mcollina merged commit 9734f4f into master Jul 6, 2013
@mcollina mcollina deleted the mongobug branch July 6, 2013 08:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants