Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

Fix RedisAscoltatore and default options to {} #84

Merged
merged 4 commits into from
Oct 22, 2013
Merged

Fix RedisAscoltatore and default options to {} #84

merged 4 commits into from
Oct 22, 2013

Conversation

davedoesdev
Copy link
Collaborator

Closes #82.

delivers message per subscription rather than per connection.
Added a test to check. Fails for MQTTAscoltatore until Mosca is fixed.
@davedoesdev
Copy link
Collaborator Author

Travis build failure is process out of memory when running coverage!

@mcollina
Copy link
Collaborator

Could you please try to restarting the job? Maybe it was a travis failure or something.
I seem not able to restart it, as it's in your repo.

@davedoesdev
Copy link
Collaborator Author

Still fails. Tried make coverage on my machine and the memory usage is large indeed. I'll see if it's this change which is making the difference (virt 2.4Gb, res 1.6Gb).

@davedoesdev
Copy link
Collaborator Author

Seems it must be this change as your repo is coveraging fine. Strange thing is the the tests don't even start - I see no mocha output.

@davedoesdev
Copy link
Collaborator Author

So coverage runs fine if I check out my master separately but as soon as I link in node_modules to the new mosca then it fails.
I think istanbul is getting confused by the links or something like that.

@davedoesdev
Copy link
Collaborator Author

Yes, it's

(cd node_modules/mosca/node_modules && rm -rf ascoltatori && ln -s ../../.. ascoltatori)

which causes it. Maybe latest istanbul gets confused by circular links.

@davedoesdev
Copy link
Collaborator Author

OK that did work - build now fails for expected reason (mosca overlapping topic failure), which will be fixed with mosca pull request when it works on 0.8...

@davedoesdev
Copy link
Collaborator Author

mosca pull is ready: moscajs/mosca#63

@mcollina
Copy link
Collaborator

Ok, merged in Mosca's master. Merging this in ascoltatori.

@mcollina mcollina merged commit 289ee00 into moscajs:master Oct 22, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple responses when using wildcards
2 participants