Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GL/DebugTools: read buffer data on WebGL 2.0 #560

Closed
wants to merge 7 commits into from
Closed

GL/DebugTools: read buffer data on WebGL 2.0 #560

wants to merge 7 commits into from

Commits on May 14, 2022

  1. GL: expose Buffer::data()/subData() on WebGL 2.0 

    Since glGetBufferSubData() is only exposed on Emscripten 2.0.17 and up,
both functions are not available on older versions. This is to avoid any
accidental foot guns since it explodes at compile time. The webgl2 CI
will be upgraded to 2.0.17 in a later commit.
    @pezcode
    pezcode committed May 14, 2022
    Configuration menu
    Copy the full SHA
    5356b43 View commit details
    Browse the repository at this point in the history

  2. DebugTools: make bufferData()/bufferSubData() default to Buffer::subD… 

    …ata()

This avoids requiring any Desktop GL extensions and allows forwarding to
Buffer::subData() also on WebGL 2.0 (in a follow-up commit)
    @pezcode
    pezcode committed May 14, 2022
    Configuration menu
    Copy the full SHA
    effebf3 View commit details
    Browse the repository at this point in the history

  3. DebugTools: make bufferData()/bufferSubData() available on WebGL 2.0

    @pezcode
    pezcode committed May 14, 2022
    Configuration menu
    Copy the full SHA
    b929cf4 View commit details
    Browse the repository at this point in the history

  4. DebugTools: handle and test size 0 in bufferData()/bufferSubData() fo… 

    …r all cases
    @pezcode
    pezcode committed May 14, 2022
    Configuration menu
    Copy the full SHA
    63dd315 View commit details
    Browse the repository at this point in the history

  5. DebugTools: make bufferSubData()'s template type default to char 

    This is already done for bufferData()
    @pezcode
    pezcode committed May 14, 2022
    Configuration menu
    Copy the full SHA
    de94fc9 View commit details
    Browse the repository at this point in the history

  6. GL, Text: verify buffer contents on GLES3

    @pezcode
    pezcode committed May 14, 2022
    Configuration menu
    Copy the full SHA
    48d97eb View commit details
    Browse the repository at this point in the history

  7. package/ci: Run emscripten-webgl2 on Emscripten 2.0.17 

    Required for Buffer::data()/subData() used by GLES3 tests. Otherwise
all the tests would have to check the Emscripten version and skip if
it's too old.
    @pezcode
    pezcode committed May 14, 2022
    Configuration menu
    Copy the full SHA
    1ae3471 View commit details
    Browse the repository at this point in the history