Fix jump if optimised appear animation is interrupted #2661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuangq
approved these changes
May 15, 2024
Comment on lines
80
to
81
| * By blocking the main thread here, we ensure that | ||
| * the keyframes |
There was a problem hiding this comment.
This comment is incomplete...?
Comment on lines
+39
to
+40
| * If we've been provided the frameloop as an argument, use it to defer | ||
| * cancellation until keyframes of the subsequent animation have been resolved. |
There was a problem hiding this comment.
Can we also elaborate a bit why we need to defer the cancellation?
mergetron
bot
force-pushed
the
fix/optimized-appear
branch
from
cad2dbd to
8e5efef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a large amount of work is performed between a deferred animation starting and keyframe resolution, there can be a perceptible jump in interrupted optimised animations. This PR fixes that by deferring cancellation until the following frame.