-
-
Notifications
You must be signed in to change notification settings - Fork 852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 19 #2667
base: main
Are you sure you want to change the base?
React 19 #2667
Conversation
For types, I'd recommend starting with |
yarn.lock
Outdated
@@ -3703,6 +3712,15 @@ __metadata: | |||
languageName: node | |||
linkType: hard | |||
|
|||
"@types/react@npm:types-react@beta": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should use resolutions
to enforce a single version of @types/react
and @types/react-dom
as suggested in the upgrade guide
Multiple versions of @types/react
is not supported just like multiple versions of react
are not supported.
@eps1lon I did try that but it didn't make any changes. Luckily I think I'm making headway with the types now. |
I just tried it in a fresh clone and it made changes to 25 files: $ npx types-react-codemod@latest preset-19 .
Processing 779 files...
Spawning 10 workers...
Results:
0 errors
753 unmodified
1 skipped
25 ok
Time elapsed: 6.403seconds |
Ah interesting, I must have done it wrong. I’ll give it another shot, thanks. |
36e92ac
to
11b72f3
Compare
So hype for this. |
215aa43
to
7570162
Compare
Thanks for pushing on this. I'm very happy to report that |
441465a
to
e4a856d
Compare
Hi @mattgperry , just curious, does:
mean that you've already made significant progress on Framer Motion 3d compatibility with React 19? I ask because I remember seeing the following warning in the docs, so it was a pleasant surprise.
|
@steve-marmalade Yeah I think 3D should be working now but that will rely on the deps defined in the |
@steve-marmalade I'm also the latest NextJS canary (
and
I basically just use a very basic |
Getting a weird bug where the opacity isn't transitioning when I refresh the page (but fixes itself if I hard refresh shift-refresh). Using NextJS. Not sure how to solve for it because this issue was introduced in upgrading the packages below. I am using framer motion in my template for the route, also using the
// src\app\template.js
'use client'
import { motion } from 'framer-motion'
const variants = {
hidden: { opacity: 0, x: 0, y: 0 },
enter: { opacity: 1, x: 0, y: 0 },
}
export default function Template({ children }) {
return (
<motion.main
variants={variants}
initial="hidden"
exit="hidden"
animate="enter"
transition={{ type: 'linear', duration: 0.25 }}
key="LandingPage"
>
{children}
</motion.main>
)
} |
@Apezdr I'm getting the same behavior. This PR that might address the issue was just merged (more info here). It will hopefully be fixed once these changes are merged in the v12 alpha version. |
Any chance we can get a alpha-1 backporting fixes since alpha-0 release? |
1d25284
to
20a5c12
Compare
@tyteen4a03 You can upgrade to |
@Apezdr In case you want to give it a try, I've tested v12.0.0-alpha.1 and this is fixed for me |
Thanks @mattgperry, that seems to fix all the issues I've been having, except for one: |
useAnimationControls is not working in Framer Motion 12? |
471c7d6
to
07641dd
Compare
Btw I'm attempting to upgrade to RC1 now. Not the smoothest process 😅 but hopefully new alpha today or Tuesday. |
42a2209
to
b8d7553
Compare
4c5d88f
to
95c5c31
Compare
Maybe you need to update Current release to |
This PR upgrades React to v19.
Fixes #2668
Current release:
12.0.0-alpha.1
Because Framer will be on React 18 perhaps for a while, the current plan is to keep this PR open, release as
12.0.0
, keepmain
for11.x
releases and rebase them into12.x
for the time being.TODO
12.0.0