fix: prevent stop or pause when drag constraints #2758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyesungoh
commented
Aug 11, 2024
Comment on lines
+231
to
+251
| it("reset drag constraints (ref-based), when click after dragging", () => { | ||
| cy.visit("?test=drag-ref-constraints&elastic=1") | ||
| .wait(200) | ||
| .get("[data-testid='draggable']") | ||
| .trigger("pointerdown", 10, 10) | ||
| .wait(200) | ||
| .trigger("pointermove", 300, 300, { force: true }) | ||
| .wait(200) | ||
| .trigger("pointerup", { force: true }) | ||
| .trigger("pointerdown", { force: true }) | ||
| .trigger("pointerup", { force: true }) | ||
| .wait(1000) | ||
| .should(($draggable: any) => { | ||
| const draggable = $draggable[0] as HTMLDivElement | ||
| const { left, top } = draggable.getBoundingClientRect() | ||
|
|
||
| expect(left).to.equal(150) | ||
| expect(top).to.equal(150) | ||
| }) | ||
| }) | ||
|
|
There was a problem hiding this comment.
I append E2E test for issue #2697
I'm wondering if it's appropriate to set wait for 1000ms 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2697
Hello there!
I appreciat your great works 👍
BTW I found some issue at above
as is
2024-08-10.4.11.08.mov
Element pause or stop when click it while dragging
https://github.com/framer/motion/blob/f59114d4d48f4fbd6a611aba62cd9ebab13e06ab/packages/framer-motion/src/gestures/drag/VisualElementDragControls.ts#L101-L103
I think it was problem
to be
2024-08-10.4.13.46.mov
So I prevent stop or pause animation when having
dragConstraintsIf you think of any related issues, please share them with me!
Thank you! 😄