fix: deep clone of default form values

movpushmov · Nov 12, 2024 · 878a236 · 878a236
1 parent 7a9093e
commit 878a236
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/packages/effector-reform-core/lib/form/form.ts b/packages/effector-reform-core/lib/form/form.ts
@@ -70,7 +70,7 @@ export function createForm<T extends AnySchema>(options: CreateFormOptions<T>) {
     metaChanged,
   } = mapSchema(fields);
 
-  const $snapshot = createStore({ ...$values.getState() });
+  const $snapshot = createStore(structuredClone($values.getState()));
 
   const $isChanged = combine(
     $values,

diff --git a/packages/effector-reform-core/tests/form/form.test.ts b/packages/effector-reform-core/tests/form/form.test.ts
@@ -718,7 +718,7 @@ describe('Form tests', () => {
       expect(watchedEvent).toBeCalledTimes(1);
     });
 
-    test('isChanged triggers when changed subfield in array field', async () => {
+    test('isChanged triggers when changed subfield in empty array field', async () => {
       const scope = fork();
       const form = createForm({
         schema: {
@@ -744,5 +744,23 @@ describe('Form tests', () => {
         'After item changed isChanged must be true',
       ).toBeTruthy();
     });
+
+    test('isChanged triggers when changed subfield in filled array field', async () => {
+      const scope = fork();
+      const form = createForm({
+        schema: {
+          arr: createArrayField<{ name: string }>([{ name: '' }]),
+        },
+      });
+
+      const item = scope.getState(form.fields.arr.$values)[0];
+
+      await allSettled(item.name.change, { scope, params: 'Edward' });
+
+      expect(
+        scope.getState(form.$isChanged),
+        'After item changed isChanged must be true',
+      ).toBeTruthy();
+    });
   });
 });