Fix all flake8 errors found in current code

e2e/helpers.py

@@ -50,11 +50,11 @@ def get_url_dict(self):
 
     def get_secure_parameter(self, parameter_name):
         """Gets the desired secret for secureStrings only from AWS Parameter Store.
-        
+
         Arguments:
             parameter_name {string} -- The name of the parameter not including the path
             to retrieve from parameter store.
-        
+
         Returns:
             [type] -- string literal decrypted value.
         """
@@ -83,11 +83,11 @@ def get_complex_structures(self):
     def ensure_appropriate_publishers_and_sign(self, fake_profile, condition):
         """Workaround the fact the FakerUser generator does not always generate valid profiles.
         Iterates over the attributes and ensures the profile will pass publisher rule validation.
-        
+
         Arguments:
             fake_profile {object} -- A fake user object of cis_profile.profile.User() type.
             condition {string} -- Takes update for create as a condition.
-        
+
         Returns:
             [type] -- A user object of type cis_profile.profile.User() with valid publishers and signatures.
         """

python-modules/cis_identity_vault/integration_tests/test_all_users.py

@@ -45,6 +45,7 @@ def get_all_by_page():
 
     logger.debug("Total records retrieved: {}".format(len(results)))
 
+
 def get_all_by_any():
     setup_environment()
     u = user.Profile(
@@ -72,6 +73,7 @@ def get_all_by_any():
         logger.info("Total records retrieved: {}".format(len(results)))
     logger.info("Total records retrieved: {}".format(len(results)))
 
+
 def test_filtered_scan(benchmark):
-    #get_all_by_any()
+    # get_all_by_any()
     benchmark.pedantic(get_all_by_any, iterations=1, rounds=1)

python-modules/cis_identity_vault/integration_tests/test_scan_speed.py

@@ -44,6 +44,7 @@ def filtered_scan_wrapper():
 
     logger.debug("Total records retrieved: {}".format(len(results)))
 
+
 def filtered_scan_wrapper_inactive():
     setup_environment()
     u = user.Profile(
@@ -63,8 +64,10 @@ def filtered_scan_wrapper_inactive():
 
     logger.debug("Total records retrieved: {}".format(len(results)))
 
+
 def test_filtered_scan(benchmark):
     benchmark.pedantic(filtered_scan_wrapper, iterations=1, rounds=1)
 
+
 def test_filtered_scan_inactive(benchmark):
-    benchmark.pedantic(filtered_scan_wrapper_inactive, iterations=1, rounds=1)
+    benchmark.pedantic(filtered_scan_wrapper_inactive, iterations=1, rounds=1)

python-modules/cis_profile_retrieval_service/cis_profile_retrieval_service/v2_api.py

@@ -99,7 +99,7 @@ def get(self, primary_email):
             vault_profile = result["Items"][0]["profile"]
             exists_in_cis = True
             exists_in_ldap = User(user_structure_json=json.loads(vault_profile)) \
-                          .as_dict()["access_information"]["ldap"]["values"] is not None
+                .as_dict()["access_information"]["ldap"]["values"] is not None
 
         return jsonify({
             "exists": {

python-modules/cis_profile_retrieval_service/tests/test_v2_api.py

@@ -355,8 +355,8 @@ def test_metadata_by_primary_email(self, fake_jwks):
             follow_redirects=True,
         )
 
-        assert query.json.get("exists").get("cis")  == True
-        assert query.json.get("exists").get("ldap") == True
+        assert query.json.get("exists").get("cis") is True
+        assert query.json.get("exists").get("ldap") is True
 
     @patch("cis_profile_retrieval_service.idp.get_jwks")
     def test_find_by_x_active_true(self, fake_jwks):

serverless-functions/identity_vault_curator/handler.py

@@ -30,6 +30,6 @@ def handle(event=None, context={}):
     v.connect()
     v.find_or_create()
     # XXX TBD if found.  Call create backup.  Support a backup and restore across tables.
-    v.tag_vault() # Vault tagging is critical to the service discovery layer.  Probably should raise and alert if it fails.
+    v.tag_vault()  # Vault tagging is critical to the service discovery layer.  Probably should raise and alert if it fails.
     v.setup_stream()
-    return 200
+    return 200