Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NR logo to it-sre team members #304

Merged
merged 2 commits into from
Jul 23, 2019
Merged

Add NR logo to it-sre team members #304

merged 2 commits into from
Jul 23, 2019

Conversation

the-smooth-operator
Copy link
Contributor

I'd like to have a New Relic icon showing in the dashboard of ITSRE team members. However the application should remain open to team_moco as it is now.

Reading how other applications are configured, this should make it. Could you please check it?

Copy link
Contributor

@gdestuynder gdestuynder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this entry already exist in the file, please modify the existing entry (look for tAtVU4uyJhaXdMEglSWKxMHliBm9yYtS)

@the-smooth-operator
Copy link
Contributor Author

@gdestuynder thanks for reviewing this. I know there's already an entry for this, I've committed it myself.

Let me explain the details of what I want:
Currently the app with client id tAtVU4uyJhaXdMEglSWKxMHliBm9yYtS is open for team_moco, and I want it to remain like this. However I'd like to add an icon to the dashboard for IT SRE team members to access NR.
If I add the icon in the existing configuration as you suggest, the icon would appear for all the members of team_moco and (most of the people) when they click, they won't be able to see anything because they don't have an account on our NR subaccount.

To achieve the behavior described, I copied the structure used by "Netlify" (See entries in lines 2 and 3547).

@gdestuynder
Copy link
Contributor

@jdow ive not done this before, can you review it?

@jdow
Copy link
Contributor

jdow commented Jul 23, 2019

I think the logic is correct. As long as this new entry doesn't have a client ID, then it should just affect the dashboard itself and do the intended behavior of providing an icon to one set of users, while the other entry handles the access control.

@jdow jdow dismissed gdestuynder’s stale review July 23, 2019 12:52

Changes not needed

@jdow jdow merged commit 7a3b4a7 into mozilla-iam:master Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants