Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Search bar text handles have violet background #1035

Closed
lucacataldo opened this issue Oct 31, 2019 · 4 comments · Fixed by #1036
Closed

Search bar text handles have violet background #1035

lucacataldo opened this issue Oct 31, 2019 · 4 comments · Fixed by #1036
Assignees
@lucacataldo
Labels
defect Issue describes a defect that negatively impacts use. effort-M Expected to take a week for engineering to complete. QA-verified For the issues verified by QA
Milestone
3.2.0 🦃

Comments

@lucacataldo
Copy link
Contributor

Steps to reproduce

  1. Login
  2. Tap search icon on top right
  3. Make text handle appear by tapping and holding in search field

Expected behavior

Text handle drawable shows up with appropriate accent color and transparent background

Actual behavior

Text handle drawable shows up with default android holo color and a background matching it's parent

Device & build information

  • Device: Present on Galaxy S8 & Nexus 5X android emulator
  • Build version: ?

Notes

Attachments:
image
@lucacataldo lucacataldo added the defect Issue describes a defect that negatively impacts use. label Oct 31, 2019
@lucacataldo
Copy link
Contributor Author

I'd like to work on this

@lucacataldo lucacataldo mentioned this issue Oct 31, 2019
Merged
6 tasks
@abodea
Copy link
Contributor

abodea commented Oct 31, 2019

Hi @lucacataldo I believe this issue is related with #298 since then the app changed but still they look similar.

@lucacataldo
Copy link
Contributor Author

Yup, looks like it is, I referenced it in my PR ( #1036 ) appears to be stemming from the main theme (and other parent themes) setting a background which is them applied to ALL child elements including handles and popup menus that would otherwise be transparent.

@marniepw marniepw added the effort-M Expected to take a week for engineering to complete. label Nov 1, 2019
eliserichards pushed a commit that referenced this issue Nov 8, 2019
@lucacataldo
1035 - Handles and context menus have solid backgrounds instead of tr…
63fb8d4 
…ansparent (#1036)

* fixed use of android:background in root theme
fixed text selection handles in filter / search
added background tags where required

* fixes #1035

* Create styles to set white background for backable filter, onboarding confirmation, settings, and nav header.

* removed unused styles
eliserichards pushed a commit that referenced this issue Nov 12, 2019
@lucacataldo
1035 - Handles and context menus have solid backgrounds instead of tr…
b8f376e 
…ansparent

* fixed use of android:background in root theme
fixed text selection handles in filter / search
added background tags where required

* fixes #1035

* Create styles to set white background for backable filter, onboarding confirmation, settings, and nav header.

* removed unused styles
@eliserichards eliserichards added the QA-needed When needing QA Verification/Investigation label Nov 14, 2019
@eliserichards eliserichards added this to the 3.2.0 milestone Nov 15, 2019
@eliserichards eliserichards mentioned this issue Nov 15, 2019
Merged
eliserichards pushed a commit that referenced this issue Nov 15, 2019
@lucacataldo
1035 - Handles and context menus have solid backgrounds instead of tr…
5ee9c43 
…ansparent

* fixed use of android:background in root theme
fixed text selection handles in filter / search
added background tags where required

* fixes #1035

* Create styles to set white background for backable filter, onboarding confirmation, settings, and nav header.

* removed unused styles
@abodea
Copy link
Contributor

abodea commented Nov 18, 2019

Verified as fixed on 3.2.0 (Build 5522) with Google Pixel 3a XL(Android 10).

@abodea abodea added QA-verified For the issues verified by QA and removed QA-needed When needing QA Verification/Investigation labels Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lucacataldo lucacataldo

Labels
defect Issue describes a defect that negatively impacts use. effort-M Expected to take a week for engineering to complete. QA-verified For the issues verified by QA
Projects
None yet
Milestone
3.2.0 🦃
Development

Successfully merging a pull request may close this issue.

1035 - Handles and context menus have solid backgrounds instead of transparent
4 participants
@marniepw @lucacataldo @abodea @eliserichards