This repository has been archived by the owner on Dec 14, 2021. It is now read-only.
992: Hide soft keyboard on unlock. #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would be nice to open an additional issue if we're not able to fix that as part of this PR. I had noticed this on 3.0 when unlocking from biometrics, but hadn't had a chance to log. |
changecourse
approved these changes
Oct 23, 2019
|
Filed #1027. |
eliserichards
force-pushed
the
992-hide-keyboard
branch
3 times, most recently
from
7e2e2ca to
9d98913
Compare
jhugman
approved these changes
Oct 31, 2019
| errorHelper.hideNetworkError(parent = view!!, child = view!!.refreshContainer.entriesView) | ||
| errorHelper.hideNetworkError( | ||
| parent = view!!, | ||
| child = view!!.refreshContainer.entriesView |
| private fun closeKeyboard() { | ||
| val imm = context?.getSystemService(Context.INPUT_METHOD_SERVICE) as InputMethodManager | ||
| imm.hideSoftInputFromWindow(view!!.windowToken, 0) | ||
| } |
There was a problem hiding this comment.
I wonder whether we should put this into the base Fragment class and call it from the base onPause() method.
eliserichards
force-pushed
the
992-hide-keyboard
branch
from
9d98913 to
aa0074b
Compare
6 tasks
eliserichards
pushed a commit
that referenced
this pull request
Oct 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #992
Testing and Review Notes
Hiding the keyboard on
onPause()for theLockedFragment. There's a little bit of a "flash" of the splash screen in between unlocking and the item list. Not sure if we should open a issue to fix that, or ...?Screenshots or Videos
To Do