Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

1010: Remove name field from edit view #1025

Merged
merged 4 commits into from
Oct 31, 2019
Merged

Conversation

eliserichards
Copy link
Contributor

@eliserichards eliserichards commented Oct 23, 2019

Fixes #1010

Testing and Review Notes

Screenshots or Videos

Item Detail screen

image

New edit screen

image

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • add unit tests
  • request the "UX" team perform a design review (if/when applicable)
  • make sure CI builds are passing (e.g.: fix lint and other errors)
  • check on the accessibility of any added UI

@eliserichards eliserichards requested a review from a team as a code owner October 23, 2019 21:24
Copy link
Contributor

@changecourse changecourse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eliserichards eliserichards force-pushed the 1010-remove-name-field branch 3 times, most recently from 6aea9ba to 985e29d Compare October 30, 2019 17:01
Copy link
Contributor

@jhugman jhugman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the .gitignore / .idea thing, this looks lovely.

.gitignore Outdated Show resolved Hide resolved
@eliserichards eliserichards force-pushed the 1010-remove-name-field branch from 985e29d to 93731e9 Compare October 31, 2019 22:38
@eliserichards eliserichards merged commit d12dbfc into master Oct 31, 2019
@eliserichards eliserichards mentioned this pull request Oct 31, 2019
6 tasks
@eliserichards eliserichards deleted the 1010-remove-name-field branch November 8, 2019 17:31
eliserichards pushed a commit that referenced this pull request Nov 15, 2019
* Remove name field from edit view. Match formatting of edit with item detail.

* Match format of password field in item detail and edit.

* Lint.

* Remove .idea from gitignore
@eliserichards eliserichards mentioned this pull request Nov 18, 2019
37 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "name" field from the edit view
3 participants