Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

768: Increase target sdk to 28 #1026

Merged
merged 1 commit into from
Oct 29, 2019
Merged

768: Increase target sdk to 28 #1026

merged 1 commit into from
Oct 29, 2019

Conversation

eliserichards
Copy link
Contributor

Fixes #768

Testing and Review Notes

Screenshots or Videos

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • add unit tests
  • request the "UX" team perform a design review (if/when applicable)
  • make sure CI builds are passing (e.g.: fix lint and other errors)
  • check on the accessibility of any added UI

@eliserichards eliserichards requested a review from a team as a code owner October 24, 2019 20:22
@eliserichards eliserichards changed the title 768: Increase target api to 28 768: Increase target sdk to 28 Oct 24, 2019
@eliserichards eliserichards requested a review from jhugman October 24, 2019 20:22
jhugman
jhugman previously requested changes Oct 26, 2019
View reviewed changes
Copy link
Contributor

@jhugman jhugman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just bump the targetSdkVersion. Let's talk about .idea f2f?

.gitignore Outdated Show resolved Hide resolved
app/build.gradle Show resolved Hide resolved
@eliserichards eliserichards force-pushed the 768-increase-target-sdk branch from 73b1cb3 to c7c83fe Compare October 28, 2019 17:21
@eliserichards eliserichards dismissed jhugman’s stale review October 28, 2019 17:21

Addressed comments :)

@eliserichards eliserichards requested a review from jhugman October 28, 2019 17:21
jhugman
jhugman approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@jhugman jhugman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Merge when ready.

@eliserichards eliserichards merged commit fe56fad into master Oct 29, 2019
@eliserichards eliserichards mentioned this pull request Oct 31, 2019
Merged
6 tasks
eliserichards pushed a commit that referenced this pull request Oct 31, 2019
Increase target sdk to 28. (#1026)
728ee37
@eliserichards eliserichards deleted the 768-increase-target-sdk branch November 8, 2019 17:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jhugman jhugman jhugman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

By November 2019, target API must be set to 28
2 participants
@eliserichards @jhugman