Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

984: Remove color state change on hostname when clicking outside of the card view #1030

Merged
merged 1 commit into from
Oct 28, 2019
Merged

984: Remove color state change on hostname when clicking outside of the card view #1030

merged 1 commit into from
Oct 28, 2019

Conversation

eliserichards
Copy link
Contributor

@eliserichards eliserichards commented Oct 25, 2019 •
edited
Loading

Fixes #984

Testing and Review Notes

Screenshots or Videos

edit_hostname_clicks

To Do

  • add “WIP” to the PR title if pushing up but not complete nor ready for review
  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • add unit tests
    • optional: consider adding instrumentation (integration/UI) tests
  • consider running this branch in a debug simulator and check for memory leak notifications or any warnings
  • request the "UX" team perform a design review (if/when applicable)
  • make sure CI builds are passing (e.g.: fix lint and other errors)
  • check on the accessibility of any added UI

@eliserichards eliserichards requested a review from a team as a code owner October 25, 2019 23:55
jhugman
jhugman approved these changes Oct 26, 2019
View reviewed changes
Copy link
Contributor

@jhugman jhugman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

changecourse
changecourse approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@changecourse changecourse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, both on the login detail page, as well as the edit login state.

@eliserichards eliserichards merged commit 1576c08 into master Oct 28, 2019
@eliserichards eliserichards mentioned this pull request Oct 31, 2019
Merged
6 tasks
eliserichards pushed a commit that referenced this pull request Oct 31, 2019
Remove color state change on hostname when clicking outside of the ca…
e25df31 
…rdview. (#1030)
@eliserichards eliserichards deleted the 984-edit-underlines branch November 8, 2019 17:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@changecourse changecourse changecourse approved these changes

@jhugman jhugman jhugman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The underlines from Name and Web address are highlighted when tapping on the screen in Edit Login page
3 participants
@eliserichards @jhugman @changecourse