Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Make autofill detection more robust #1031

Merged
merged 8 commits into from
Oct 30, 2019
Merged

Make autofill detection more robust #1031

merged 8 commits into from
Oct 30, 2019

Conversation

jhugman
Copy link
Contributor

@jhugman jhugman commented Oct 26, 2019 •
edited
Loading

Fixes #765.
Fixes #615.

This PR makes detection of autofillable pages significantly better.

  • Detects text input by inputType, instead of class name.
  • Distinguish between username and password fields even without any autofillHints from the app.
  • Don't rely on localized hints.
  • Recognizes adjacent username and password fields.
  • Recognizes the form that the user is focused on, in supporting webviews.

Apps Tested:

  • Facebook
  • Facebook Lite
  • Messenger
  • Messenger Lite
  • Twitter
  • Twitter Lite
  • Firefox Accounts (for Pocket)
  • Apple ID (for Pocket)
  • Amazon
  • Fortuneo
  • Google Accounts

Tested in Fenix

  • Facebook
  • Twitter
  • Fortuneo
  • Google Accounts

Tested in Fennec

  • Facebook

Still failing:

  • Amazon in Fenix. GeckoView 1591737 is relevant here.
  • Firefox Accounts in Fenix.
  • Saving Wifi passwords in the Settings app.

Also added:

  • More XML files to test new apps
  • Added isFocused and isHtmlForm to navigator.

@jhugman jhugman requested a review from a team as a code owner October 26, 2019 21:19
@jhugman jhugman force-pushed the jhugman/765-make-autofill-detection-more-robust branch from 86347ed to 9920254 Compare October 26, 2019 21:56
@jhugman jhugman self-assigned this Oct 26, 2019
@jhugman jhugman force-pushed the jhugman/765-make-autofill-detection-more-robust branch from 4292a0f to 987c96a Compare October 29, 2019 17:51
eliserichards
eliserichards approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@eliserichards eliserichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic. Thank you for the thorough testing notes. I added a commit to put the MPL on all of the /debug/assets/ files.

@jhugman jhugman merged commit afbd758 into master Oct 30, 2019
@jhugman jhugman deleted the jhugman/765-make-autofill-detection-more-robust branch October 30, 2019 14:55
@jhugman jhugman mentioned this pull request Oct 31, 2019
Closed
@eliserichards eliserichards mentioned this pull request Oct 31, 2019
Merged
6 tasks
eliserichards pushed a commit that referenced this pull request Oct 31, 2019
@jhugman
Make autofill detection more robust (#1031)
37e266a 
* Make autofill detection more robust

* Look for adjacent text field and password field

* Get from multiple forms

* Add support for looking for in focus forms. Not working due to GeckoView

* Added Apple ID example XML file

* Now auth0 works

* ./gradlew lint

* Add lincense to fixtures.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eliserichards eliserichards eliserichards approved these changes

Assignees

@jhugman jhugman

Labels
feature-autofill
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Username/password can't be autofilled on Fortuneo app Autofill menu is not displayed on Facebook (fennec)
2 participants
@jhugman @eliserichards