Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Bump the required Android Components version to 19.0.1 #1070

Merged

Conversation

Dexterp37
Copy link
Contributor

@Dexterp37 Dexterp37 commented Nov 18, 2019

This is the first version that comes with a Rust implementation of the Glean SDK and is the suggested starting version for integrating with the Glean SDK.

Currently failing

e: E:\Mozilla\lockwise-android\app\src\main\java\mozilla\lockbox\store\AccountStore.kt: (284, 24): Type mismatch: inferred type is KFunction1<@ParameterName String, Unit> but Consumer<in AuthFlowUrl!>! was expected
e: E:\Mozilla\lockwise-android\app\src\main\java\mozilla\lockbox\store\AccountStore.kt: (284, 60): Type mismatch: inferred type is KFunction1<@ParameterName Throwable, Unit> but Consumer<in Throwable!>! was expected

Connected to #127

To Do

  • fix compilation errors

This is the first version that comes with a Rust implementation
of the Glean SDK.
@Dexterp37 Dexterp37 self-assigned this Nov 18, 2019
@Dexterp37
Copy link
Contributor Author

@jhugman is this a reasonable bump? Do you have any suggestion on how to fix the build error?

@Dexterp37
Copy link
Contributor Author

@jhugman is this a reasonable bump? Do you have any suggestion on how to fix the build error?

Unping, I think I fixed this :)

@Dexterp37 Dexterp37 marked this pull request as ready for review November 19, 2019 08:24
@Dexterp37 Dexterp37 requested a review from a team as a code owner November 19, 2019 08:24
@Dexterp37 Dexterp37 changed the title WIP: Bump the required Android Components version to 19.0.1 Bump the required Android Components version to 19.0.1 Nov 19, 2019
@Dexterp37 Dexterp37 mentioned this pull request Nov 19, 2019
2 tasks
Copy link
Contributor

@eliserichards eliserichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd like a second opinion from @jhugman 👀 🤞

@Dexterp37
Copy link
Contributor Author

LGTM, but I'd like a second opinion from @jhugman 👀 🤞

Totally makes sense! This is such a huge version bump that might be relevant to have QA on it, if you have resources for that!

Copy link
Contributor

@jhugman jhugman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. I'd like to land this independently of #1073.

It is a large version bump, however, due to the great work by the android-components team, there is minimal API changes.

@eliserichards eliserichards merged commit 71b63e4 into mozilla-lockwise:master Nov 20, 2019
eliserichards pushed a commit that referenced this pull request Nov 26, 2019
* Bump the required Android Components version to 19.0.1

This is the first version that comes with a Rust implementation
of the Glean SDK.

* Fix AccountStore.kt after upgrading to A-C 19.0.1

* Suppress deprecation notice for service-telemetry

This is required since Lockwise fails to build due to
errors after upgrading to A-C 19.0.1

* Implement the missing methods in `MockLoginsStorage.kt`
@eliserichards eliserichards added this to the 3.3.0 🥧 milestone Nov 26, 2019
@eliserichards eliserichards added QA-needed When needing QA Verification/Investigation a-c issues corresponding to android-components work labels Nov 26, 2019
@abodea
Copy link
Contributor

abodea commented Nov 28, 2019

Verified as fixed on the v3.3.0 with Google Pixel 3a XL(Android 10).

This being a very big update, I was not really sure what to verify. @Dexterp37 told me that I should verify that everything works as expected and Lockwise is not broken.

Note that I didn't encounter any issues(0 crashes) while performing different tests.
Is there something else that I should look into or just the normal workflow?

I will add the QA Verified label based on my comment.
@eliserichards @jhugman I would appreciate a confirmation that everything looks good regarding my comment, thanks!

@abodea abodea added QA-verified For the issues verified by QA and removed QA-needed When needing QA Verification/Investigation labels Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a-c issues corresponding to android-components work QA-verified For the issues verified by QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants