-
Notifications
You must be signed in to change notification settings - Fork 98
Bump the required Android Components version to 19.0.1 #1070
Bump the required Android Components version to 19.0.1 #1070
Conversation
This is the first version that comes with a Rust implementation of the Glean SDK.
@jhugman is this a reasonable bump? Do you have any suggestion on how to fix the build error? |
This is required since Lockwise fails to build due to errors after upgrading to A-C 19.0.1
Unping, I think I fixed this :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'd like a second opinion from @jhugman 👀 🤞
Totally makes sense! This is such a huge version bump that might be relevant to have QA on it, if you have resources for that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine. I'd like to land this independently of #1073.
It is a large version bump, however, due to the great work by the android-components team, there is minimal API changes.
* Bump the required Android Components version to 19.0.1 This is the first version that comes with a Rust implementation of the Glean SDK. * Fix AccountStore.kt after upgrading to A-C 19.0.1 * Suppress deprecation notice for service-telemetry This is required since Lockwise fails to build due to errors after upgrading to A-C 19.0.1 * Implement the missing methods in `MockLoginsStorage.kt`
Verified as fixed on the This being a very big update, I was not really sure what to verify. @Dexterp37 told me that I should verify that everything works as expected and Lockwise is not broken. Note that I didn't encounter any issues(0 crashes) while performing different tests. I will add the |
This is the first version that comes with a Rust implementation of the Glean SDK and is the suggested starting version for integrating with the Glean SDK.
Currently failingConnected to #127
To Do