This repository has been archived by the owner on Dec 14, 2021. It is now read-only.
Fix interrupts causing the app to go to the item list. #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhugman
commented
Nov 20, 2019
| .doOnNext { | ||
| credentialsAtStart = it | ||
| } | ||
|
|
||
| getItem | ||
| .filter { credentialsToSave == null } |
There was a problem hiding this comment.
Don't override edits when switching apps.
eliserichards
previously requested changes
Nov 20, 2019
There was a problem hiding this comment.
Additional cases to explore:
- From a fresh install, login/use test data. See that the onboarding confirmation screen does not route to the ItemList when
Finishis clicked - Set autolock to 1 minute. From the item detail screen select
Deleteand keep the dialog box open. Background the app and wait for it to lock. See that theDeletedialog is shown over the lock screen. Also happens with Auto lock menu:
Successful manual tests:
- Delete dialog stays open above item detail screen after home button interrupt ✅
- Delete dialog
Cancelworks correctly after home button interrupt ✅ - Delete dialog
Deleteworks correctly after home button interrupt ✅ - Auto lock dialog stays open above settings screen after home button interrupt ✅
- Auto lock persists new value chosen from dialog after home button interrupt ✅
jhugman
force-pushed
the
jhugman/987-itemlist-after-interrupt
branch
from
3edc126 to
cca87d4
Compare
jhugman
force-pushed
the
jhugman/987-itemlist-after-interrupt
branch
from
6ff1589 to
895a8cf
Compare
eliserichards
pushed a commit
that referenced
this pull request
Nov 26, 2019
* Ensure unlocking doesn't route to ItemList if unlocked already * Ensure in flight editing is not overwritten when re-starting the edit screen * Allow existing dialogs to still work * Allow radio dialog to work after interupt * Add tests and lint * Make sure the finish button works to go from onboarding to the itemlist * Rewrite dialogs so as to be dismissable on disposal
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #987
This PR makes a number of changes:
ItemListin the instances of the app not being at theLockScreen.EditItemDetailscreen after an interrupt; this was revealed by fixing the original bug.Note, this fixes #987 by making the app restore correctly, rather than dismissing the dialog and taking us back to itemlist.