This repository has been archived by the owner on Dec 14, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1079
Testing and Review Notes
If a user is now set his/her phone as locale=zh_CN & language = Chinese, and the lockwise apk is not downloaded from Google play, there should be a way for the user to switch the service before login. After login, there should be no toggle button for switching service in settings.
Else there should be no "switch service" option, just like before.
Screenshots or Videos
To Do
The existed tests are all passed but I'm still working on the tests related to these new features
The default value of local service/global service is not really runtime. It is set during app firstrun; if change the locale and language setting later, the default value won't change with the new settings.