This repository has been archived by the owner on Dec 14, 2021. It is now read-only.
Fixup autofill footer in dark mode. #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ddurst Please could you review this, when you have a second. |
|
@jhugman I just tried this branch to check the UI and saw that it is shown fine, but if you tap on the Search option the app crashes :( |
|
Hello, I have some more information regarding the crash issue: The crash can be reproduced only when a website(example facebook) is opened from the entries list(from Lockwise) and tapping on the If I open the browser manually and I tap on the I can reproduce the crash by opening a website from the entries list(lockwise) only on the latest build with the change from this PR. Crashlog
--------- beginning of crash
2019-12-18 17:12:42.688 18419-18544/mozilla.lockbox E/AndroidRuntime: FATAL EXCEPTION: DefaultDispatcher-worker-9
Process: mozilla.lockbox, PID: 18419
io.reactivex.exceptions.OnErrorNotImplementedException: The exception was not handled due to missing onError handler in the subscribe() method call. Further reading: https://github.com/ReactiveX/RxJava/wiki/Error-Handling | Should be on the UI thread
at io.reactivex.internal.functions.Functions$OnErrorMissingConsumer.accept(Functions.java:704)
at io.reactivex.internal.functions.Functions$OnErrorMissingConsumer.accept(Functions.java:701)
at io.reactivex.internal.observers.LambdaObserver.onError(LambdaObserver.java:77)
at io.reactivex.internal.observers.LambdaObserver.onNext(LambdaObserver.java:67)
at io.reactivex.internal.util.NotificationLite.accept(NotificationLite.java:246)
at io.reactivex.subjects.BehaviorSubject$BehaviorDisposable.test(BehaviorSubject.java:569)
at io.reactivex.subjects.BehaviorSubject$BehaviorDisposable.emitNext(BehaviorSubject.java:564)
at io.reactivex.subjects.BehaviorSubject.onNext(BehaviorSubject.java:268)
at mozilla.lockbox.store.ItemDetailStore$1.accept(ItemDetailStore.kt:41)
at mozilla.lockbox.store.ItemDetailStore$1.accept(ItemDetailStore.kt:20)
at io.reactivex.internal.observers.LambdaObserver.onNext(LambdaObserver.java:63)
at io.reactivex.internal.operators.observable.ObservableMap$MapObserver.onNext(ObservableMap.java:62)
at io.reactivex.internal.operators.observable.ObservableFilter$FilterObserver.onNext(ObservableFilter.java:52)
at io.reactivex.subjects.PublishSubject$PublishDisposable.onNext(PublishSubject.java:308)
at io.reactivex.subjects.PublishSubject.onNext(PublishSubject.java:228)
at mozilla.lockbox.flux.Dispatcher.dispatch(Dispatcher.kt:22)
at mozilla.lockbox.presenter.AutofillRoutePresenter$onViewReady$6.invoke(AutofillRoutePresenter.kt:77)
at mozilla.lockbox.presenter.AutofillRoutePresenter$onViewReady$6.invoke(AutofillRoutePresenter.kt:35)
at mozilla.lockbox.presenter.AutofillRoutePresenter$sam$io_reactivex_functions_Consumer$0.accept(Unknown Source:6)
at io.reactivex.internal.observers.LambdaObserver.onNext(LambdaObserver.java:63)
at io.reactivex.internal.operators.observable.ObservableMap$MapObserver.onNext(ObservableMap.java:62)
at io.reactivex.internal.operators.observable.ObservableSwitchMap$SwitchMapObserver.drain(ObservableSwitchMap.java:297)
at io.reactivex.internal.operators.observable.ObservableSwitchMap$SwitchMapInnerObserver.onSubscribe(ObservableSwitchMap.java:355)
at io.reactivex.internal.operators.observable.ObservableJust.subscribeActual(ObservableJust.java:34)
at io.reactivex.Observable.subscribe(Observable.java:12090)
at io.reactivex.internal.operators.observable.ObservableSwitchMap$SwitchMapObserver.onNext(ObservableSwitchMap.java:127)
at io.reactivex.internal.operators.observable.ObservableFilter$FilterObserver.onNext(ObservableFilter.java:52)
at com.jakewharton.rxrelay2.ReplayRelay$SizeBoundReplayBuffer.replay(ReplayRelay.java:637)
at com.jakewharton.rxrelay2.ReplayRelay.accept(ReplayRelay.java:220)
at mozilla.lockbox.store.DataStore$unlockInternal$4.invoke(DataStore.kt:305)
at mozilla.lockbox.store.DataStore$unlockInternal$4.invoke(DataStore.kt:39)
at mozilla.lockbox.store.DataStore$sam$io_reactivex_functions_Consumer$0.accept(Unknown Source:6)
at io.reactivex.internal.observers.LambdaObserver.onNext(LambdaObserver.java:63)
at io.reactivex.internal.operators.observable.ObservableMap$MapObserver.onNext(ObservableMap.java:62)
at io.reactivex.internal.operators.observable.ObservableTake$TakeObserver.onNext(ObservableTake.java:64)
at io.reactivex.internal.operators.observable.ObservableSkip$SkipObserver.onNext(ObservableSkip.java:56)
at io.reactivex.internal.operators.observable.ObservableDoOnEach$DoOnEachObserver.onNext(ObservableDoOnEach.java:101)
at io.reactivex.internal.operators.observable.ObservableSwitchMap$SwitchMapObserver.drain(ObservableSwitchMap.java:297)
2019-12-18 17:12:42.689 18419-18544/mozilla.lockbox E/AndroidRuntime: at io.reactivex.internal.operators.observable.ObservableSwitchMap$SwitchMapInnerObserver.onNext(ObservableSwitchMap.java:374)
at com.jakewharton.rxrelay2.BehaviorRelay$BehaviorDisposable.test(BehaviorRelay.java:354)
at com.jakewharton.rxrelay2.BehaviorRelay$BehaviorDisposable.emitNext(BehaviorRelay.java:348)
at com.jakewharton.rxrelay2.BehaviorRelay.accept(BehaviorRelay.java:127)
at mozilla.lockbox.store.DataStore$updateList$1.accept(DataStore.kt:384)
at mozilla.lockbox.store.DataStore$updateList$1.accept(DataStore.kt:39)
at io.reactivex.internal.observers.ConsumerSingleObserver.onSuccess(ConsumerSingleObserver.java:62)
at io.reactivex.internal.operators.single.SingleCreate$Emitter.onSuccess(SingleCreate.java:67)
at kotlinx.coroutines.rx2.RxSingleCoroutine.onCompleted(RxSingle.kt:45)
at kotlinx.coroutines.AbstractCoroutine.onCompletionInternal(AbstractCoroutine.kt:102)
at kotlinx.coroutines.JobSupport.tryFinalizeSimpleState(JobSupport.kt:275)
at kotlinx.coroutines.JobSupport.tryMakeCompleting(JobSupport.kt:807)
at kotlinx.coroutines.JobSupport.makeCompletingOnce$kotlinx_coroutines_core(JobSupport.kt:787)
at kotlinx.coroutines.AbstractCoroutine.resumeWith(AbstractCoroutine.kt:111)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:46)
at kotlinx.coroutines.DispatchedTask.run(Dispatched.kt:241)
at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:594)
at kotlinx.coroutines.scheduling.CoroutineScheduler.access$runSafely(CoroutineScheduler.kt:60)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:740)
Caused by: java.lang.AssertionError: Should be on the UI thread
at mozilla.lockbox.support.DebugSupportKt.assertOnUiThread(DebugSupport.kt:17)
at mozilla.lockbox.support.DebugSupportKt.assertOnUiThread$default(DebugSupport.kt:15)
at mozilla.lockbox.view.ItemDetailFragment.setPasswordVisible(ItemDetailFragment.kt:98)
at mozilla.lockbox.presenter.ItemDetailPresenter$onViewReady$12.accept(ItemDetailPresenter.kt:145)
at mozilla.lockbox.presenter.ItemDetailPresenter$onViewReady$12.accept(ItemDetailPresenter.kt:54)
at io.reactivex.internal.observers.LambdaObserver.onNext(LambdaObserver.java:63)
... 53 more |
eliserichards
suggested changes
Dec 31, 2019
| @@ -12,6 +12,7 @@ | |||
| android:layout_width="wrap_content" | |||
| android:layout_height="wrap_content" | |||
| android:theme="@style/AppTheme" | |||
| android:background="@color/background_white" | |||
There was a problem hiding this comment.
I don't think this is the right place to define the background since it creates the overdraw error. I would prefer it to be set in the styles or explicitly set when the autofill dialog is created.
jhugman
force-pushed
the
jhugman/1072-fixup-autofill-footer-darkmode
branch
from
eeed1f5 to
53abf37
Compare
eliserichards
approved these changes
Jan 9, 2020
| @@ -138,10 +138,12 @@ class DisplayItemPresenter( | |||
| .addTo(compositeDisposable) | |||
|
|
|||
| networkStore.isConnected | |||
| .observeOn(mainThread()) | |||
| @@ -11,8 +11,8 @@ | |||
| xmlns:android="http://schemas.android.com/apk/res/android" | |||
| android:layout_width="wrap_content" | |||
| android:layout_height="wrap_content" | |||
| android:theme="@style/AppTheme" | |||
| > | |||
| style="@style/AutofillRemoteViewSyle"> | |||
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1072.
This PR is a one liner which sets the background of the call to action at the bottom of the autofill dialogs.
This is both the Unlock Lockwise and Search Lockwise footers.