-
Notifications
You must be signed in to change notification settings - Fork 98
1084: Update app services to version 0.46.0 #1124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems painless!
Not quite that easy! The state is stuck in a login loop: Logcat from first try logging in:
on second try:
|
I have been to get to the item list screen:
I've been unable to get to the item list screen:
|
Regarding the // Determined from
// https://github.com/mozilla-mobile/android-components/blob/v19.0.1/buildSrc/src/main/java/Dependencies.kt,
// where the version in the URL is the tag corresponding to `android_components_version`.
ext.mozilla_appservices_version = '0.46.0' So it looks like we have a mismatch between Lockwise's version of logins and android-components version. I suspect the least painful thing to do here is to bump the A-C version up to a version such that A-S is high enough, then get our dependency versions (i.e. A-S and Glean) to match those versions. We should also review if these dependencies are being included twice. |
9284011
to
258d096
Compare
The latest version of android components - |
258d096
to
e1c3b98
Compare
Is Glean affected by this too? We should check that the glean version is the same as the one shipping with A-S and A-C. |
Tried to look for any places we may have had null usernames/pwds instead of "" empty string. Only found one in a test. Let me know if you can think of other places that might break with the |
110c387
to
57a4ba4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
For a change like this we should bake this for a little while before releasing.
Purely for my own curiosity about process, could you please tell me whether you saw the notices in the changelog about how this version of appservices introduces new telemetry and the application should check that it has the appropriate data reviews? (Lockwise got data-review for these metrics over in Bug 1597895 so there was no action you to take, I'm just curious if you were aware of that change in particular) |
Fixes #1084
Testing and Review Notes
Screenshots or Videos
To Do