Fixup edit regressions introduced during edit/create refactor. #1133

jhugman · 2020-01-10T14:59:54Z

This fixes three bugs:

in the edit screen, the save button saved, but did not exit the screen. This is the root cause of all these bugs.
in the edit screen, the duplicate usernames were updated on save, and thence caused an error to be shown. This is irrelevant if the the save button now closes the edit screen.
when no hostname is shown (as in create) the usernames used to detect duplicates was all usernames for all hostnames. This is now prevented. This was unreported.

eliserichards

LGTM! 🚀

eliserichards · 2020-01-13T16:16:20Z

app/src/main/java/mozilla/lockbox/store/ItemDetailStore.kt

            .map { (opt, list) ->
                val item = opt.value ?: return@map emptySet<String>()

                val usernames = list
                    .filter(
-                        hostname = item.hostname,
+                        // Default to a blank space, otherwise we get all usernames for any hostname.
+                        hostname = if (item.hostname.isNullOrBlank()) " " else item.hostname,


Why would the hostname ever be null/blank? This doesn't seem like a valid case to me

hostname is blank in the case of Manual Create.

jhugman added 3 commits January 10, 2020 14:34

Stop editing after saving the edited item.

3dcbadc

Prevent usernames being re-calculated on save.

1142452

Don't select any usernames when hostname is blank.

a55b714

jhugman requested a review from a team as a code owner January 10, 2020 14:59

eliserichards approved these changes Jan 13, 2020

View reviewed changes

jhugman merged commit ab09aeb into master Jan 13, 2020

jhugman deleted the jhugman/1126-fixup-duplicat-username-error-on-save-in-edit branch January 13, 2020 16:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixup edit regressions introduced during edit/create refactor. #1133

Fixup edit regressions introduced during edit/create refactor. #1133

jhugman commented Jan 10, 2020

eliserichards left a comment

eliserichards Jan 13, 2020

jhugman Jan 13, 2020

Fixup edit regressions introduced during edit/create refactor. #1133

Fixup edit regressions introduced during edit/create refactor. #1133

Conversation

jhugman commented Jan 10, 2020

eliserichards left a comment

Choose a reason for hiding this comment

eliserichards Jan 13, 2020

Choose a reason for hiding this comment

jhugman Jan 13, 2020

Choose a reason for hiding this comment