This repository has been archived by the owner on Dec 14, 2021. It is now read-only.
Show errors in create and edit only after the user makes one #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliserichards
previously requested changes
Jan 17, 2020
Comment on lines
+119
to
+118
| // We use a marker error for an error we don't tell the user about, | ||
| // but will cause the save button to be disabled. |
app/src/main/java/mozilla/lockbox/presenter/ItemMutationPresenter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/mozilla/lockbox/presenter/ItemMutationPresenter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/mozilla/lockbox/presenter/ItemMutationPresenter.kt
Outdated
Show resolved
Hide resolved
| override val togglePasswordClicks: Observable<Unit> | ||
| get() = view!!.btnPasswordToggle.clicks().mergeWith(togglePasswordVisibility) | ||
| get() = view!!.btnPasswordToggle.clicks().mergeWith(passwordFocus.map { Unit }) |
| @@ -55,6 +53,15 @@ open class ItemMutationFragment : BackableFragment(), ItemMutationView { | |||
| override val passwordChanged: Observable<String> | |||
| get() = view!!.inputPassword.textChanges().map { it.toString() } | |||
|
|
|||
| override val hostnameFocus | |||
| get() = focusChanges(view!!.inputHostname) | |||
There was a problem hiding this comment.
Can we use view?.inputHostname here?
There was a problem hiding this comment.
(Same with pwd and username)
There was a problem hiding this comment.
No. This is a well established pattern.
Additionally, passing an optional to focusChanges means we get an optional back. We should fail fast here if there is a problem with the layout.xml.
| view.inputPassword?.setSelection(view.inputPassword?.length() ?: 0) | ||
| } | ||
| } | ||
| open fun setupKeyboardFocus(view: View) { |
There was a problem hiding this comment.
Can this be removed now?
There was a problem hiding this comment.
The Edit and Create subclasses are still called. I don't understand the code enough to say if those methods can be rendered obsolete.
I've added comment to this effect.
|
Bitrise failure: |
jhugman
force-pushed
the
jhugman/1120-show-errors-only-after-user-error
branch
from
0dd952a to
af4eb72
Compare
jhugman
force-pushed
the
jhugman/1120-show-errors-only-after-user-error
branch
2 times, most recently
from
d2cd427 to
58cca7d
Compare
jhugman
force-pushed
the
jhugman/1120-show-errors-only-after-user-error
branch
from
58cca7d to
e4537a6
Compare
eliserichards
approved these changes
Jan 23, 2020
|
@eliserichards Also fixes #1131 |
|
Thank you @turkergoksu! Good catch! 🔥 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1120
This includes a number of fixes in displaying errors during manual create, which is inherited by edit.
httporhttpsthen don't show an error until they make a mistake