Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Update string names to send update upstream to l10n #1142

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Update string names to send update upstream to l10n #1142

merged 1 commit into from
Jan 22, 2020

Conversation

eliserichards
Copy link
Contributor

@eliserichards eliserichards commented Jan 17, 2020 •
edited
Loading

Fixes #1138

  • Changes the name of the onboarding strings to force an update upstream in l10n (the security onboarding string was previously two different strings, but has been simplified to one - see Import strings from android-l10n. #1138)

@eliserichards eliserichards requested a review from a team as a code owner January 17, 2020 16:16
@eliserichards eliserichards added the import-l10n Used by l10n team to track requests across repos (@Pike) label Jan 17, 2020
@eliserichards eliserichards self-assigned this Jan 17, 2020
jhugman
jhugman approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@jhugman jhugman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge when ready!

@eliserichards eliserichards merged commit c3243fc into master Jan 22, 2020
@Pike
Copy link
Contributor

Pike commented Jan 22, 2020

Can you detail on why you changed three string IDs here?

CC @Delphine

@eliserichards eliserichards added this to the 4.0.0 🆕 milestone Jan 29, 2020
@Delphine
Copy link
Contributor

@eliserichards: I think the question here is why you have changed three string IDs when only one string needed to be changed. In fact, we're going to lose existing translations for all three strings since the IDs are changed).
Is it for consistency in string IDs perhaps? Otherwise, it would be better to just change one.
thanks!

@eliserichards
Copy link
Contributor Author

Yes it is for consistency. Since I changed one of the string names it was necessary to change the two others that relate to it. @Delphine

@Delphine
Copy link
Contributor

Delphine commented Feb 5, 2020

Ok thanks Elise!

@eliserichards eliserichards deleted the update-strings-l10n branch February 11, 2020 15:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jhugman jhugman jhugman approved these changes

@Delphine Delphine Awaiting requested review from Delphine

Assignees

@eliserichards eliserichards

Labels
import-l10n Used by l10n team to track requests across repos (@Pike)
Projects
None yet
Milestone
4.0.0 🆕 - Manual Create
Development

Successfully merging this pull request may close these issues.
4 participants
@eliserichards @Pike @Delphine @jhugman