This repository has been archived by the owner on Dec 14, 2021. It is now read-only.
Use red trash icon and fix deleted string #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changecourse
previously requested changes
Jan 23, 2020
changecourse
approved these changes
Jan 23, 2020
|
Verified as fixed on v.4.0.0(6016) using Google Pixel 3 XL(Android 9), Samsung Galaxy S10+(Android 9). |
abodea
added
QA-verified
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the toast notification that is shown after you delete an item. In order to match the designs, the icon needed to be changed to the red trash can, and the string should read "deleted" and not "deleted." with a period. This PR also fixed the padding between the toast icon and text as well as the vertical placement of the toast notification being above the create
+button on the Item List.Design: https://app.zeplin.io/project/5b6895bfe4af825140aa8dbc/screen/5c548fc44e168142a92bee1d