1152: Toast placement for copy, create, delete

[eliserichards]

Fixes #1152

Specify each bottom margin for the toast notifications. The bottomMargin value set based on the nav location: toasts on the item list will appear above the + create button, and other toasts will have the normal bottom margin at the bottom of the screen.

Testing and Review Notes

• copy username/copy password appear at the bottom of the screen
• delete confirmation appears above the + button on the item list
• create confirmation appears on the item detail screen at the bottom (same place as copy)

Screenshots or Videos

(save gif tbd on #1163)

To Do

• double check the original issue to confirm it is fully satisfied
• add testing notes and screenshots in PR description to help guide reviewers
• add unit tests
  • optional: consider adding instrumentation (integration/UI) tests
• consider running this branch in a debug simulator and check for memory leak notifications or any warnings
• request the "UX" team perform a design review (if/when applicable)
• make sure CI builds are passing (e.g.: fix lint and other errors)
• check on the accessibility of any added UI

[jhugman]

I'm conflicted about this. If we land this patch as is, we're incurring some avoidable technical debt.

However, I'm not sure that toast notification is going to be used more than we have it, and I don't think that this is going to cause enough friction to development as to have something done about it.

I have left two paths forward in the comment; decide if and which you want to do, and then let's conflab.

Addressed comments, the easy way ;)

[jhugman]

Almost there. I won't make you do another review cycle, but I'd like you to make the changes as suggested.

[jhugman]

Easy: choose the bottom margin based on whether or not the current destination is the ItemList.

val bottomMargin = if (navController.currentDestination?.id == R.id.fragment_item_list) {

[jhugman]

This way we can make all toasts that are displayed on the Item List avoid the + button, not just the delete one.

[eliserichards]

Oh that makes perfect sense. Done.

[jhugman]

This is good.