-
Notifications
You must be signed in to change notification settings - Fork 97
Use 'org.mozilla.appservices' Gradle plugin to consume single megazor… #353
Conversation
I'm curious whether this will impact anyone's emulator / on-computer usage? But barring that I see no reason to keep |
If anybody is running an So all told I think that means this can Just Land (after manual testing, please!) without regressing your architecture story, and we can pursue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 🎉
Thanks @ncalexan! Unless anyone objects, I will do some manual/device testing tomorrow-ish on this branch and merge assuming everything looks OK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested Build 2054 both on Pixel 2 and this big Samsung Galaxy Note 5 and successfully: signed in, synced real data, re-sorted list, loaded FxA avatar and display name, opened webviews, locked and unlocked. ✅
…d lib. (#352)
Fixes #352
Fixes #242
Related to #242, #337
I notice that Lockbox is currently configured for x86_64, but I don't think that a-s is producing any x86_64 binaries: mozilla/application-services#426. If we're confident that x86_64 support is needed, this is blocked by that ticket. If not, I think we can land this without x86_64 support, since it's the status quo.
Testing and Review Notes
This follows the Reference Browser model and the documentation.
This needs to be tested (manually, or on emulators that actually open SQLite DBs) on devices of different architectures:
It works fine on my armeabi-v7a device (an old Galaxy S6, I think).