This repository has been archived by the owner on Dec 14, 2021. It is now read-only.
514 text error is not correctly aligned #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #514
Testing and Review Notes
I could not reproduce the issue as described in the ticket, so I just faked the text in
FingerprintAuthDialogFragment.onFailed.Screenshots or Videos
To Do
double check the original issue to confirm it is fully satisfied
add testing notes and screenshots in PR description to help guide reviewers
request the "UX" team perform a design review (if/when applicable)
check on the accessibility of any added UI