Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

383: Change font in spinner item list #540

Merged
merged 2 commits into from
Mar 26, 2019
Merged

383: Change font in spinner item list #540

merged 2 commits into from
Mar 26, 2019

Conversation

deandreamatias
Copy link
Contributor

Fixes #383

Testing and Review Notes

To see the problem, I visually compared the title of the list screen with titles from other screens (account, settings, etc).
It was found that the first title was lighter than the others.

Screenshots or Videos

Before
Screenshot_20190326-131049

After
Screenshot_20190326-131012

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • request the "UX" team perform a design review (if/when applicable)
  • check on the accessibility of any added UI

@deandreamatias deandreamatias requested a review from a team as a code owner March 26, 2019 13:06
@ghost ghost added the in progress label Mar 26, 2019
Copy link
Contributor

@sashei sashei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 🎨 thanks for the contribution @deandreamatias !!

@sashei sashei merged commit 6cc9266 into mozilla-lockwise:master Mar 26, 2019
@ghost ghost removed the in progress label Mar 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants