Issue #295 - Add empty implementations to observer interfaces of Sess…

…ion and EngineView.
mozilla-mobile · Jun 12, 2018 · 791a6e7 · 791a6e7
1 parent 75b7689
commit 791a6e7
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/components/browser/session/src/main/java/mozilla/components/browser/session/Session.kt b/components/browser/session/src/main/java/mozilla/components/browser/session/Session.kt
@@ -21,13 +21,13 @@ class Session(
      * Interface to be implemented by classes that want to observe a session.
      */
     interface Observer {
-        fun onUrlChanged()
-        fun onProgress()
-        fun onLoadingStateChanged()
-        fun onNavigationStateChanged()
-        fun onSearch()
-        fun onSecurityChanged()
-        fun onCustomTabConfigChanged() { }
+        fun onUrlChanged() = Unit
+        fun onProgress() = Unit
+        fun onLoadingStateChanged() = Unit
+        fun onNavigationStateChanged() = Unit
+        fun onSearch() = Unit
+        fun onSecurityChanged() = Unit
+        fun onCustomTabConfigChanged() = Unit
     }
 
     /**

diff --git a/components/concept/engine/src/main/java/mozilla/components/concept/engine/EngineSession.kt b/components/concept/engine/src/main/java/mozilla/components/concept/engine/EngineSession.kt
@@ -18,11 +18,11 @@ abstract class EngineSession : Observable<EngineSession.Observer> by registry {
      * Interface to be implemented by classes that want to observe this engine session.
      */
     interface Observer {
-        fun onLocationChange(url: String)
-        fun onProgress(progress: Int)
-        fun onLoadingStateChange(loading: Boolean)
-        fun onNavigationStateChange(canGoBack: Boolean? = null, canGoForward: Boolean? = null)
-        fun onSecurityChange(secure: Boolean, host: String? = null, issuer: String? = null)
+        fun onLocationChange(url: String) = Unit
+        fun onProgress(progress: Int) = Unit
+        fun onLoadingStateChange(loading: Boolean) = Unit
+        fun onNavigationStateChange(canGoBack: Boolean? = null, canGoForward: Boolean? = null) = Unit
+        fun onSecurityChange(secure: Boolean, host: String? = null, issuer: String? = null) = Unit
     }
 
     /**